Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](Serde-2.1) fix potential mem leak in array serde write_one_cell_to_json #41339

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

eldenmoon
Copy link
Member

@eldenmoon eldenmoon commented Sep 26, 2024

placement new may lead to mem leak in Field without calling it's desctructor

…json

placement new may lead to mem leak in Field without calling it's desctructor

related PR apache#40573
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@eldenmoon
Copy link
Member Author

run buildall

@eldenmoon eldenmoon changed the title [Fix](Serde) fix potential mem leak in array serde write_one_cell_to_json [Fix](Serde-2.1) fix potential mem leak in array serde write_one_cell_to_json Sep 26, 2024
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.14% (9343/25853)
Line Coverage: 27.67% (76762/277436)
Region Coverage: 26.43% (39392/149049)
Branch Coverage: 23.22% (20050/86364)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5528094bf79a2917adeacd1606a52614bd5dcbfa_5528094bf79a2917adeacd1606a52614bd5dcbfa/report/index.html

@yiguolei yiguolei merged commit 9ec54e9 into apache:branch-2.1 Sep 26, 2024
20 of 24 checks passed
@eldenmoon eldenmoon deleted the branch-2.1 branch September 27, 2024 01:51
@yiguolei yiguolei mentioned this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants