Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress self update for windows CI runner #9661

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Suppress self update for windows CI runner #9661

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ac8a2e
suppress self update for window
jayzhan211 Mar 18, 2024
aa8e1bf
Update .github/actions/setup-windows-builder/action.yaml
alamb Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/setup-windows-builder/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ runs:
- name: Setup Rust toolchain
shell: bash
run: |
rustup update stable
rustup toolchain install stable
# Avoid self update to avoid CI failures: https://github.com/apache/arrow-datafusion/issues/9653
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add the same for other OS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@comphead I think we don't need to disable self update for other OS, the issue is window only. After the issue is solved, we can enable self update again.
@alamb

rustup toolchain install stable --no-self-update
alamb marked this conversation as resolved.
Show resolved Hide resolved
rustup default stable
rustup component add rustfmt
- name: Configure rust runtime env
Expand Down
Loading