-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress self update for windows CI runner #9661
Conversation
Signed-off-by: jayzhan211 <[email protected]>
I create a new label Let me introduce more lable, so one for critical issue that is blocking every PR, another is normal that happens sometime like this one, the last one is the normal feature request. |
ci: critial, ci: important and ci: feature I think critical and feature are nice name, but unsure is there a better label for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jayzhan211
I think our windows CI jobs run on windows latest:
https://github.com/apache/arrow-datafusion/blob/eb13f598fa722382cb6580ff9fc31e458ad7a8a9/.github/workflows/rust.yml#L292
WHich appears to be updated with the latest version of rustup: https://github.com/actions/runner-images/blob/main/images/windows/Windows2022-Readme.md
@@ -38,8 +38,8 @@ runs: | |||
- name: Setup Rust toolchain | |||
shell: bash | |||
run: | | |||
rustup update stable | |||
rustup toolchain install stable | |||
# Avoid self update to avoid CI failures: https://github.com/apache/arrow-datafusion/issues/9653 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add the same for other OS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging to stop CI failures on main -- let's contemplate adding the same for other OS's (@comphead 's comment #9661 (comment)) as a follow on PR |
Which issue does this PR close?
Close #9653
Sometimes CI fails because of rustup, we can re-reun the job and pray for the success.
There is a workaround solution so we can avoid manually re-run CI job.
Downside is that we need to manual update latest rust version for window.
Possible issue
rust-lang/rustup#2441
rust-lang/rustup#3709
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?