UDAF and UDWF support aliases #9489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
|
Clippy failure is fixed in #9486 |
lewiszlw
force-pushed
the
udaf-uawf-aliases
branch
from
00ac44a to
1f151ea
Compare
alamb
reviewed
Mar 8, 2024
There was a problem hiding this comment.
Thank you @lewiszlw -- this is a great feature.
Can you please add some tests so that if this feature gets broken by accident in a future refactoring we would have a test failure?
Perhaps you could add a test like https://github.com/apache/arrow-datafusion/blob/a68f1cbb0c31f263bfa4c7920482e689ffe1ee89/datafusion/core/tests/user_defined/user_defined_scalar_functions.rs#L369-L389
In
- https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/user_defined/user_defined_aggregates.rs
- https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/user_defined/user_defined_window_functions.rs
respectively?
|
Sure, I can. |
Thank you @lewiszlw ! |
|
🚀 Thanks again @lewiszlw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
UDAF and UDWF should have aliases like UDF.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?