Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI build] fix chrono suggestions #9486

Merged
merged 4 commits into from
Mar 7, 2024
Merged

[CI build] fix chrono suggestions #9486

merged 4 commits into from
Mar 7, 2024

Conversation

comphead
Copy link
Contributor

@comphead comphead commented Mar 7, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

Chrono deprecated bunch of methods and clippy now complains, so the CI build fails

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added physical-expr Physical Expressions optimizer Optimizer rules core Core DataFusion crate labels Mar 7, 2024
@comphead comphead requested review from alamb, andygrove and viirya March 7, 2024 03:48
@comphead comphead changed the title [CI] fix chrono suggestions [CI build] fix chrono suggestions Mar 7, 2024
Copy link
Member

@Ted-Jiang Ted-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems and_utc() only used in test method

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@waynexia waynexia merged commit e5404a1 into apache:main Mar 7, 2024
25 checks passed
@comphead
Copy link
Contributor Author

comphead commented Mar 7, 2024

Thanks @waynexia and @Ted-Jiang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate optimizer Optimizer rules physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants