Minor: Add ScalarValue::data_type() for consistency with other APIs
#7492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
alamb
changed the title
ScalarValue::data_type() for consistency with other APIs
Dandandan
approved these changes
Sep 7, 2023
viirya
reviewed
Sep 7, 2023
Comment on lines
+1152
to
+1157
| /// Getter for the `DataType` of the value. | ||
| /// | ||
| /// Suggest using [`Self::data_type`] as a more standard API | ||
| pub fn get_datatype(&self) -> DataType { | ||
| self.data_type() | ||
| } |
There was a problem hiding this comment.
We could/should -- I was basically being lazy.
I'll try and find time to bash out a follow on PR to deprecate it and update the uses.
viirya
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
The fact that most of the DataFusion codebase uses
fn data_type()to retrieve the datatype butScalarValueusesget_datatypeis frustrating to me. It is a very small rough edge, but one that is easy to fixHere is the example showing exsiting APIs that use
data_type(): https://github.com/search?q=repo%3Aapache%2Farrow-datafusion%20data_type&type=codeWhat changes are included in this PR?
ScalarValue::data_type()ScalarValue::get_datatypeNote I did not actually
#deprecateget_datatype as I thought that would be too large a change. I can do so if people would like however.Are these changes tested?
I changed a few locations to call
ScalarValue::data_typeAre there any user-facing changes?