Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ScalarValue::get_datatype() #7506

Closed
alamb opened this issue Sep 8, 2023 · 1 comment · Fixed by #7507
Closed

Deprecate ScalarValue::get_datatype() #7506

alamb opened this issue Sep 8, 2023 · 1 comment · Fixed by #7507
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@alamb
Copy link
Contributor

alamb commented Sep 8, 2023

Is your feature request related to a problem or challenge?

We introduced ScalarValue::data_type() in #7492 to be consistent with other APIs for getting DataType.

However the previous ScalarValue::get_datatype()

#7492 (comment)

Describe the solution you'd like

  1. Mark ScalarValue::get_datatype() deprecated (like this):

https://github.com/apache/arrow-datafusion/blob/93c209f1b5d0a17b2aa5c6743cbd3cb189a406c8/datafusion/expr/src/table_source.rs#L81-L87

  1. Update the uses in the datafusion codebase to pass clippy (update to use ScalarValue::data_type())

Describe alternatives you've considered

No response

Additional context

No response

@Weijun-H
Copy link
Member

Weijun-H commented Sep 8, 2023

I will be glad to handle this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants