Implement serialization for UDWF and UDAF in plan protobuf #6769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @alamb I am not sure this is good implement?😊 |
alamb
reviewed
Jun 27, 2023
| row_number_frame, | ||
| )); | ||
| ctx.register_udaf(dummy_agg); |
There was a problem hiding this comment.
THis is great!
Now all we need is a test for the WindowUDF (aka WindowFunction::WindowUDF) and I think this PR is ready to go!
| @@ -585,16 +585,16 @@ impl TryFrom<&Expr> for protobuf::LogicalExprNode { | |||
| ) | |||
| } | |||
| // TODO: Tracked in https://github.com/apache/arrow-datafusion/issues/4584 | |||
There was a problem hiding this comment.
Perhaps we can remove the TODO comments as well
|
Thanks @alamb , I will update the test case lately.😄 |
alamb
reviewed
Jun 29, 2023
| values: &[ArrayRef], | ||
| range: &std::ops::Range<usize>, | ||
| ) -> Result<ScalarValue> { | ||
| // Again, the input argument is an array of floating |
There was a problem hiding this comment.
Perhaps we can just use todo!() here and in the other functions? These should not be called during the logical plan testing
2010YOUY01
pushed a commit
to 2010YOUY01/arrow-datafusion
that referenced
this pull request
Jul 5, 2023
* update * update udwf test * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4584 #6733
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?