Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement serialization for UDWF as window function in plan protobuf #4584 #6733

Closed
alamb opened this issue Jun 20, 2023 · 5 comments
Closed
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Jun 20, 2023

Is your feature request related to a problem or challenge?

Similarly to #4584

Follow on to #6703 to add serialization support for user defined window functions when serializing plans

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

@alamb alamb added the enhancement New feature or request label Jun 20, 2023
@parkma99
Copy link
Contributor

I would like to work this.Could you give me some tips for starting this issue?

@alamb
Copy link
Contributor Author

alamb commented Jun 24, 2023

The basic idea would be to fix this code: https://github.com/apache/arrow-datafusion/blob/80d1750fda0f8d1d09d7bbf5b05662b1f6618954/datafusion/proto/src/logical_plan/to_proto.rs#L593-L597

I think you can generally follow the model of AggregateUDF

So I would recommend this order:

  1. Write a round trip test first -- following the model of https://github.com/apache/arrow-datafusion/blob/80d1750fda0f8d1d09d7bbf5b05662b1f6618954/datafusion/proto/src/logical_plan/mod.rs#L2606-L2663
  2. Write the code

@parkma99
Copy link
Contributor

I think you can generally follow the model of AggregateUDF

@alamb Thanks, I will have a look late.😊

@Jefffrey
Copy link
Contributor

This issue looks good to close?

cc @alamb

@alamb
Copy link
Contributor Author

alamb commented Oct 30, 2023

I agree -- thanks @Jefffrey (and @parkma99 !)

@alamb alamb closed this as completed Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants