feat: encapsulate physical optimizer rules into a struct #6645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <[email protected]>
jackwener
approved these changes
Jun 12, 2023
jackwener
reviewed
Jun 12, 2023
jackwener
force-pushed
the
physical-optimizer
branch
from
ef34dbb to
fe32605
Compare
|
Thanks for reviewing it ❤️
🥹 It would be useful when I want to adjust the order of rules (by removing it and inserting a new one). But it's ok since the inner vector is public anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Make a new struct
PhysicalOptimizerto hold all physical optimizer rules. LikeOptimizerfor logical rules andAnalyzerfor analyzer rules. I found it's not very convenient when I want to customize physical optimize rules.What changes are included in this PR?
New struct
PhysicalOptimizerand several related methods on it.Are these changes tested?
yes
Are there any user-facing changes?
It's a public struct