Skip to content

Commit

Permalink
remove redundant code
Browse files Browse the repository at this point in the history
  • Loading branch information
jackwener committed Jun 12, 2023
1 parent dbdf8d5 commit fe32605
Showing 1 changed file with 0 additions and 30 deletions.
30 changes: 0 additions & 30 deletions datafusion/core/src/physical_optimizer/optimizer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -124,34 +124,4 @@ impl PhysicalOptimizer {
pub fn with_rules(rules: Vec<Arc<dyn PhysicalOptimizerRule + Send + Sync>>) -> Self {
Self { rules }
}

/// Remove the first rule that [PhysicalOptimizerRule::name] equals to the given name.
/// Return whether a rule is removed.
pub fn remove_rule(&mut self, name: &str) -> bool {
let mut index_to_move = None;
for (index, rule) in self.rules.iter().enumerate() {
if rule.name() == name {
index_to_move = Some(index);
break;
}
}

if let Some(index) = index_to_move {
self.rules.remove(index);
}

index_to_move.is_some()
}
}

#[cfg(test)]
mod test {
use super::*;

#[test]
fn remove_enforce_sorting_rule() {
let mut optimizer = PhysicalOptimizer::new();
assert!(optimizer.remove_rule(EnforceSorting {}.name()));
assert!(!optimizer.remove_rule(EnforceSorting {}.name()));
}
}

0 comments on commit fe32605

Please sign in to comment.