Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use modulus dyn kernels for arithmetic expressions #5634

Merged
merged 4 commits into from
Mar 20, 2023
Merged

Use modulus dyn kernels for arithmetic expressions #5634

merged 4 commits into from
Mar 20, 2023

Conversation

viirya
Copy link
Member

@viirya viirya commented Mar 17, 2023 •
edited
Loading

Which issue does this PR close?

Closes #5642.

Rationale for this change

What changes are included in this PR?

We should use dyn kernels for modulus too.

Are these changes tested?

Are there any user-facing changes?

@viirya viirya marked this pull request as draft March 17, 2023 23:04
@github-actions github-actions bot added the physical-expr Physical Expressions label Mar 17, 2023
@viirya
Copy link
Member Author

viirya commented Mar 17, 2023

I'll add test later.

@viirya viirya marked this pull request as ready for review March 19, 2023 18:10
@viirya viirya changed the title Use modulus dyn kernels Use modulus dyn kernels for arithmetic expressions Mar 19, 2023
@viirya viirya merged commit d77ccc2 into apache:main Mar 20, 2023
@viirya
Copy link
Member Author

viirya commented Mar 20, 2023

Thanks @Dandandan for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dandandan Dandandan Dandandan approved these changes

Assignees
No one assigned
Labels
physical-expr Physical Expressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use modulus dyn kernels for arithmetic expressions
2 participants
@viirya @Dandandan