Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use modulus dyn kernels for arithmetic expressions #5642

Closed
viirya opened this issue Mar 19, 2023 · 0 comments · Fixed by #5634
Closed

Use modulus dyn kernels for arithmetic expressions #5642

viirya opened this issue Mar 19, 2023 · 0 comments · Fixed by #5634
Labels
enhancement New feature or request

Comments

@viirya
Copy link
Member

viirya commented Mar 19, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

We updated arithmetic kernels to use dyn kernels in previous PR. At that time, modulus kernels were not updated because arrow-rs didn't provide these kernels yet. As we updated the upstream, we can use modulus dyn kernels now.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant