Update datafusion-substrait crate to build against repo version of DataFusion #4879
Conversation
andygrove
changed the title
andygrove
force-pushed
the
substrait-integrate
branch
from
869d3c4 to
2bb03a6
Compare
| @@ -33,15 +33,15 @@ mod tests { | |||
| let sql = "SELECT a, b FROM data"; | |||
| // Test reference | |||
| let df_ref = ctx.sql(sql).await?; | |||
| let plan_ref = df_ref.to_logical_plan()?; | |||
| let plan_ref = df_ref.into_optimized_plan()?; | |||
There was a problem hiding this comment.
I hadn't noticed when this changed from "to_optimized" to "to_unoptimized". But as discussed in datafusion-contrib/datafusion-substrait#35, maybe we need not to cover optimization in serialize/deserialize phase?
|
Benchmark runs are scheduled for baseline = 82bbaa3 and contender = 9247022. 9247022 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Follows on from #4543
Rationale for this change
Updates the crate to build against the version of DataFusion in the repo.
I could not add it to the workspace due to #4880 so there will be a follow-on PR to complete the integration at some point
What changes are included in this PR?
Are these changes tested?
Yes, existing tests
Are there any user-facing changes?