Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datafusion-substrait to workspace #4880

Closed
andygrove opened this issue Jan 11, 2023 · 1 comment · Fixed by #4893
Closed

Add datafusion-substrait to workspace #4880

andygrove opened this issue Jan 11, 2023 · 1 comment · Fixed by #4893
Labels
enhancement New feature or request

Comments

@andygrove
Copy link
Member

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
PR #4879 updates datafusion-substrait so that it builds correctly against the version of the datafusion in the repo but I could not add it to the workspace due to a build failure in Windows in CI.

 error: failed to run custom build command for `substrait v0.2.0`

Caused by:
  process didn't exit successfully: `D:\a\arrow-datafusion\arrow-datafusion\target\debug\build\substrait-a6509fbb99b47d6b\build-script-build` (exit code: 1)
  --- stdout
  cargo:rerun-if-env-changed=FORCE_REBUILD

  --- stderr
  Error: "protobuf compilation failed: protoc failed: Missing input file.\r\n"

Describe the solution you'd like
Fix the build issue and add the crate to he workspace

Describe alternatives you've considered

Additional context

@waynexia
Copy link
Member

I noticed that commits in datafusion-contrib/datafusion-substrait after Dec 7, 2022 are not included. How do we handle them? Not sure if upgrading to substrait v0.3 can resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants