Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy #3182

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Fix clippy #3182

merged 1 commit into from
Aug 16, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Aug 16, 2022

Which issue does this PR close?

re #3175

Rationale for this change

I accidentally merged #3175 ever though there was a clippy error 🤦

What changes are included in this PR?

Fix clippy errors

Are there any user-facing changes?

No

@alamb alamb marked this pull request as ready for review August 16, 2022 21:00
@github-actions github-actions bot added the optimizer Optimizer rules label Aug 16, 2022
@alamb alamb merged commit 23866cd into apache:master Aug 16, 2022
@alamb alamb deleted the alamb/fix_clippy branch August 16, 2022 21:04
@alamb
Copy link
Contributor Author

alamb commented Aug 16, 2022

Merging this one in quickly so I don't leave master broken very long

@ursabot
Copy link

ursabot commented Aug 16, 2022

Benchmark runs are scheduled for baseline = fe42dd7 and contender = 23866cd. 23866cd is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimizer Optimizer rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants