Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recursively apply remove filter rule if filter is a true scalar value #3175

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Recursively apply remove filter rule if filter is a true scalar value #3175

merged 3 commits into from
Aug 16, 2022

Conversation

jonahgao
Copy link
Member

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the optimizer Optimizer rules label Aug 16, 2022
alamb
alamb reviewed Aug 16, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @byteink -- this is looking good. I'll trigger the CI jobs

datafusion/optimizer/src/eliminate_filter.rs Outdated Show resolved Hide resolved
datafusion/optimizer/src/eliminate_filter.rs Outdated Show resolved Hide resolved
@alamb alamb changed the title Recursively apply rule if filter is a true scalar value Recursively apply remove filter rule if filter is a true scalar value Aug 16, 2022
alamb
alamb approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @byteink

@alamb alamb merged commit 54fb92e into apache:master Aug 16, 2022
@alamb
Copy link
Contributor

alamb commented Aug 16, 2022

Whoops -- I think I accidentally merged this with a clippy error -- will fix

@alamb alamb mentioned this pull request Aug 16, 2022
Merged
@alamb
Copy link
Contributor

alamb commented Aug 16, 2022

Clippy fix in #3182

@ursabot
Copy link

ursabot commented Aug 16, 2022

Benchmark runs are scheduled for baseline = fbdb6f4 and contender = 54fb92e. 54fb92e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
optimizer Optimizer rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonahgao @alamb @ursabot