Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant (and currently broken) RAT check #3053

Merged
merged 1 commit into from
Aug 6, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Aug 6, 2022

Which issue does this PR close?

Closes #3052
re #3045

Rationale for this change

RAT is the license checker that ensures that all files in this repo have an appropriate license in the header

It turns out that datafusion CU runs 2 RAT checks:

  1. dev/scripts/run-rat.sh (which is also what is run to verify the release when a tarball is created)
  2. an "archery" based one left over from when we split DataFusion out of the main arrow repository. Its name gives you a hint it is crufty: Lint C++, Python, R, Rust, Docker

Since the checks are redundant and the archery one started failing in #3052 I propose to remove the archery job

Note that "archery" is a python-based workflow tool used for t

What changes are included in this PR?

Remove redundant and failing check "Lint C++, Python, R, Rust, Docker"

Are there any user-facing changes?

No

@alamb alamb added the development-process Related to development process of DataFusion label Aug 6, 2022
@alamb alamb marked this pull request as ready for review August 6, 2022 10:45
@codecov-commenter
Copy link

Codecov Report

Merging #3053 (752710e) into master (941b9a2) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3053      +/-   ##
==========================================
- Coverage   85.84%   85.84%   -0.01%     
==========================================
  Files         289      289              
  Lines       51862    51862              
==========================================
- Hits        44521    44519       -2     
- Misses       7341     7343       +2     
Impacted Files Coverage Δ
datafusion/core/src/physical_plan/metrics/value.rs 86.93% <0.00%> (-0.51%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 77.43% <0.00%> (-0.18%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@andygrove andygrove merged commit a8ed874 into apache:master Aug 6, 2022
@ursabot
Copy link

ursabot commented Aug 6, 2022

Benchmark runs are scheduled for baseline = 0b3130b and contender = a8ed874. a8ed874 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/fix_ci branch August 6, 2022 12:29
- name: Setup Archery
run: pip install -e dev/archery[lint]
- name: Lint
run: archery lint --rat

rat:
name: Release Audit Tool (RAT)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to point out the current RAT check is right here (immediately below) 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of DataFusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint check fails on master: apache-rat license violation: js/test.ts
5 participants