-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant (and currently broken) RAT check #3053
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3053 +/- ##
==========================================
- Coverage 85.84% 85.84% -0.01%
==========================================
Files 289 289
Lines 51862 51862
==========================================
- Hits 44521 44519 -2
- Misses 7341 7343 +2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Benchmark runs are scheduled for baseline = 0b3130b and contender = a8ed874. a8ed874 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
- name: Setup Archery | ||
run: pip install -e dev/archery[lint] | ||
- name: Lint | ||
run: archery lint --rat | ||
|
||
rat: | ||
name: Release Audit Tool (RAT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to point out the current RAT check is right here (immediately below) 😆
Which issue does this PR close?
Closes #3052
re #3045
Rationale for this change
RAT is the license checker that ensures that all files in this repo have an appropriate license in the header
It turns out that datafusion CU runs 2 RAT checks:
dev/scripts/run-rat.sh
(which is also what is run to verify the release when a tarball is created)arrow
repository. Its name gives you a hint it is crufty:Lint C++, Python, R, Rust, Docker
Since the checks are redundant and the archery one started failing in #3052 I propose to remove the archery job
Note that "archery" is a python-based workflow tool used for t
What changes are included in this PR?
Remove redundant and failing check "Lint C++, Python, R, Rust, Docker"
Are there any user-facing changes?
No