-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
to_timestamp i32 coerced to i64 #3047
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
could anyone help me to figure this error? (for this first check Run archery lint --rat
archery lint --rat
shell: /usr/bin/bash -e {0}
env:
pythonLocation: /opt/hostedtoolcache/Python/[3](https://github.com/apache/arrow-datafusion/runs/7698281962?check_suite_focus=true#step:5:3).10.5/x6[4](https://github.com/apache/arrow-datafusion/runs/7698281962?check_suite_focus=true#step:5:4)
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.10.[5](https://github.com/apache/arrow-datafusion/runs/7698281962?check_suite_focus=true#step:5:5)/x[6](https://github.com/apache/arrow-datafusion/runs/7698281962?check_suite_focus=true#step:5:6)4/lib
INFO:archery:Running apache-rat linter
apache-rat license violation: js/test.ts
Error: Process completed with exit code 1. |
Codecov Report
@@ Coverage Diff @@
## master #3047 +/- ##
=======================================
Coverage 85.84% 85.85%
=======================================
Files 289 289
Lines 51862 51890 +28
=======================================
+ Hits 44520 44549 +29
+ Misses 7342 7341 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
@alamb would you mind helping me figure out my first check? I've committed dummy commits to trigger this several times. |
https://github.com/apache/arrow-datafusion/runs/7699097645?check_suite_focus=true
This means (very unobviously) that the file Interestingly, this test is also failing on master changes too -- I will get a PR up to fix it |
#3052 tracks the CI failure |
#3053 should "fix" the problem -- TLDR is that the the CI check failure is not related to your changes in this PR @waitingkuo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @waitingkuo -- other than the test coverage looks good to me!
async fn to_timestamp_i32() -> Result<()> { | ||
let ctx = SessionContext::new(); | ||
|
||
let sql = "select to_timestamp(cast (1 as int));"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please add to_timestamp_seconds(..)
, to_timestamp_milliseconds(..)
etc here?
38d1ff7
to
883c85a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- thanks @waitingkuo
Benchmark runs are scheduled for baseline = a8ed874 and contender = 815f1bc. 815f1bc is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3046
Rationale for this change
What changes are included in this PR?
change the oreder for
to_timestamp
signagure. make int64 be in front of utf8Are there any user-facing changes?