Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add print format param with support for tsv print format to datafusion cli #292

Merged
merged 4 commits into from
May 10, 2021

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented May 8, 2021

Which issue does this PR close?

Closes #293 .

Rationale for this change

Since we now have #289 , we can easily add tsv support

What changes are included in this PR?

Extending format to include tsv

Are there any user-facing changes?

If there are user-facing changes then we may require documentation to be updated before approving the PR.

If there are any breaking changes to public APIs, please add the breaking change label.

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2021

Codecov Report

Merging #292 (dc25b3e) into master (a00f410) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #292      +/-   ##
==========================================
- Coverage   75.99%   75.98%   -0.01%     
==========================================
  Files         141      141              
  Lines       23673    23675       +2     
==========================================
  Hits        17990    17990              
- Misses       5683     5685       +2     
Impacted Files Coverage Δ
datafusion-cli/src/format/print_format.rs 0.00% <0.00%> (ø)
datafusion-cli/src/main.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a00f410...dc25b3e. Read the comment docs.

@jimexist jimexist changed the title Add tsv format mode to datafusion cli as well Add print format param and support for tsv print format to datafusion cli May 9, 2021
@jimexist jimexist changed the title Add print format param and support for tsv print format to datafusion cli Add print format param witg support for tsv print format to datafusion cli May 9, 2021
@jimexist jimexist changed the title Add print format param witg support for tsv print format to datafusion cli Add print format param with support for tsv print format to datafusion cli May 9, 2021
@Dandandan
Copy link
Contributor

Thanks @jimexist !

@Dandandan Dandandan merged commit dcf6c11 into apache:master May 10, 2021
@jimexist jimexist deleted the add-tsv-mode branch May 25, 2021 12:56
@houqp houqp added datafusion Changes in the datafusion crate enhancement New feature or request labels Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tsv output format support for datafusion cli
4 participants