chore(deps): Update sqlparser to 0.54.0
#14255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
alamb
commented
Jan 23, 2025
alamb
commented
Jan 23, 2025
| query ? | ||
| select interval '5' years | ||
| ---- | ||
| 5.000000000 secs | ||
|
|
||
| 60 mons |
There was a problem hiding this comment.
this certainly seems much more correct to me -- I also removed the now out of date comment.
| @@ -984,84 +984,141 @@ impl<S: ContextProvider> SqlToRel<'_, S> { | |||
| Ok(Expr::Cast(Cast::new(Box::new(expr), dt))) | |||
| } | |||
|
|
|||
| fn sql_subscript_to_expr( | |||
| fn sql_compound_field_access_to_expr( | |||
There was a problem hiding this comment.
The code to plan CompoundFieldAccess is directly copy/pasted from @goldmedal 's PR
alamb
changed the title
0.54.0
alamb
commented
Jan 27, 2025
| /// | ||
| /// For example, `foo.bar` would be represented as a two element vector | ||
| /// `["foo", "bar"]` | ||
| fn from_idents(mut idents: Vec<String>) -> Option<Self> { |
There was a problem hiding this comment.
Changed the signature to be easier to work with (pass the vec by ownership rather than &mut)
goldmedal
approved these changes
Feb 5, 2025
Comment on lines
+2626
to
+2628
| # left_join_using_qualified (snowflake syntax) | ||
| query error DataFusion error: This feature is not implemented: Invalid identifier in USING clause\. Expected single identifier, got t2\.c2 | ||
| SELECT t1.c1, t2.c2 FROM test_partition_table t1 JOIN test_partition_table t2 USING (t2.c2) ORDER BY t2.c2; |
|
@alamb There are some conflicts here. |
Co-authored-by: Jax Liu <[email protected]>
… into alamb/upgrade_sqlparser
Thank you for the review @goldmedal -- I have merged up and resolved the conflicts |
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Keep up with latest SQL parser dependencies
What changes are included in this PR?
Are these changes tested?
Yes by CI
Are there any user-facing changes?