Test upgrade to sqlparser-rs 0.54 #14198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
alamb
force-pushed
the
alamb/sqlparser_upgrade_test
branch
from
98938a9 to
8632bdd
Compare
alamb
commented
Jan 19, 2025
| SQLExpr::Subscript { expr, subscript } => { | ||
| self.sql_subscript_to_expr(*expr, subscript, schema, planner_context) | ||
| } | ||
| SQLExpr::CompoundFieldAccess { root, access_chain } => self |
There was a problem hiding this comment.
The code to plan CompoundFieldAccess is directly copy/pasted from @goldmedal 's PR
| @@ -44,7 +44,7 @@ Interval(MonthDayNano) Interval(MonthDayNano) | |||
| query ? | |||
| select interval '5' years | |||
| ---- | |||
| 5.000000000 secs | |||
| 60 mons | |||
There was a problem hiding this comment.
this certainly seems much more correct to me -- I also removed the now out of date comment.
6 tasks
alamb
force-pushed
the
alamb/sqlparser_upgrade_test
branch
from
8632bdd to
5bb20ad
Compare
alamb
commented
Jan 19, 2025
| /// | ||
| /// For example, `foo.bar` would be represented as a two element vector | ||
| /// `["foo", "bar"]` | ||
| pub fn from_idents(mut idents: Vec<String>) -> Option<Self> { |
There was a problem hiding this comment.
i made this public and cleaned up the signature so I could reuse it when dealing with the changes to USING planning
However I am not quite sure what a USING(foo.bar) would actually mean 🤔 Maybe when joining across multiple schemas...
I could also revert this change and just make the planner error if it got a multi-part ObjectName in a USING clause ..
|
Superceded by #14255 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
0.54.0datafusion-sqlparser-rs#1597Rationale for this change
I want to test the upgrade to the latest sqlparser before we release a new version of sqlparser as a sanity check / test downstream implications
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?