Implement EXCEPT & EXCEPT DISTINCT #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datafusion
|
PTAL, thanks❤️ @alamb @houqp @Dandandan |
houqp
reviewed
Nov 6, 2021
datafusion/src/sql/planner.rs
Outdated
| @@ -195,26 +195,42 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { | |||
| } => { | |||
| let left_plan = self.set_expr_to_plan(left.as_ref(), None, ctes)?; | |||
| let right_plan = self.set_expr_to_plan(right.as_ref(), None, ctes)?; | |||
| let join_keys = left_plan | |||
There was a problem hiding this comment.
i am a bit concerned about the extra overhead here for the union branches. perhaps also relevant to https://github.com/apache/arrow-datafusion/pull/1258/files#r744178212
xudong963
force-pushed
the
impl_except
branch
3 times, most recently
from
392a134 to
7cedf95
Compare
|
I extracted some duplicate code, you can review this ticket firstly. After the ticket is merged, I'll update #1258 and #1261 @houqp @alamb @Dandandan |
Dandandan
reviewed
Nov 7, 2021
datafusion/tests/sql.rs
Outdated
| let sql = "SELECT * FROM (SELECT null AS id1, 1 AS id2) t1 | ||
| EXCEPT SELECT * FROM (SELECT null AS id1, 2 AS id2) t2"; | ||
|
|
||
| let expected: Vec<Vec<String>> = vec![vec!["NULL".to_string(), "1".to_string()]]; |
There was a problem hiding this comment.
Using &str is possible here too I think, maybe easier to remove the explicit type.
xudong963
force-pushed
the
impl_except
branch
from
7cedf95 to
f192309
Compare
houqp
approved these changes
Nov 8, 2021
datafusion/src/sql/planner.rs
Outdated
Comment on lines
245
to
250
| LogicalPlanBuilder::intersect_or_except( | ||
| left_plan, | ||
| right_plan, | ||
| JoinType::Semi, | ||
| false, | ||
| ) |
There was a problem hiding this comment.
i think it would be cleaner to turn this and except into a simple public wrapper method in logical plan builder so users won't need to worry about which join type to pass in.
xudong963
force-pushed
the
impl_except
branch
from
f192309 to
550473d
Compare
alamb
approved these changes
Nov 8, 2021
| } | ||
|
|
||
| /// Process intersect or except | ||
| fn intersect_or_except( |
| "Only UNION ALL and UNION [DISTINCT] and INTERSECT and INTERSECT [DISTINCT] are supported, found {}", | ||
| op | ||
| ))), | ||
| (SetOperator::Union, true) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1082
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?