Add DataFrame support for INTERSECT and update readme
#1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datafusion
|
Make DataFrame users have the |
houqp
approved these changes
Nov 6, 2021
houqp
reviewed
Nov 6, 2021
| @@ -231,6 +231,29 @@ impl DataFrame for DataFrameImpl { | |||
| .build()?, | |||
| ))) | |||
| } | |||
|
|
|||
| fn intersect(&self, dataframe: Arc<dyn DataFrame>) -> Result<Arc<dyn DataFrame>> { | |||
There was a problem hiding this comment.
looks like there is some code duplication between this and the one in sql planner, perhaps better to move this into logical plan builder so it can be reused in both places.
alamb
reviewed
Nov 8, 2021
datafusion/src/dataframe.rs
Outdated
| @@ -375,4 +375,19 @@ pub trait DataFrame: Send + Sync { | |||
| /// # } | |||
| /// ``` | |||
| fn registry(&self) -> Arc<dyn FunctionRegistry>; | |||
|
|
|||
| /// Calculate the intersect two [`DataFrame`]s. The two [`DataFrame`]s must have exactly the same schema | |||
There was a problem hiding this comment.
Suggested change
| /// Calculate the intersect two [`DataFrame`]s. The two [`DataFrame`]s must have exactly the same schema | |
| /// Calculate the intersection of two [`DataFrame`]s. The two [`DataFrame`]s must have exactly the same schema |
Comment on lines
252
to
254
| &LogicalPlanBuilder::from(left_plan) | ||
| .join_detailed(&right_plan, JoinType::Semi, join_keys, true)? | ||
| .build()?, |
There was a problem hiding this comment.
I think once we merge #1259 this could just call LogicalPlanBuilder::intersect
xudong963
force-pushed
the
intersect_df
branch
from
cae6e55 to
d045dbd
Compare
|
The ticket has been done! |
houqp
approved these changes
Nov 9, 2021
alamb
changed the title
INTERSECT and update readme
|
Looks great -- thank you @xudong963 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1082
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?