Minor: Improve documentation in sql_to_plan example #10582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
May 20, 2024
| Ok(()) | ||
| } | ||
|
|
||
| /// DataFusion can convert expressions to SQL, using column name escaping | ||
| /// PostgreSQL style. | ||
| fn simple_expr_to_sql_demo() -> Result<()> { | ||
| let expr = col("a").lt(lit(5)).or(col("a").eq(lit(8))); | ||
| let ast = expr_to_sql(&expr)?; | ||
| let sql = format!("{}", ast); | ||
| let sql = expr_to_sql(&expr)?.to_string(); |
There was a problem hiding this comment.
I think it makes it easier to use this example if we don't have to worry about the intermediate ast as much, so I combined it into a single statement
There was a problem hiding this comment.
I don't remember why I had to do it, that totally makes sense
edmondop
approved these changes
May 20, 2024
| Ok(()) | ||
| } | ||
|
|
||
| /// DataFusion can convert expressions to SQL, using column name escaping | ||
| /// PostgreSQL style. | ||
| fn simple_expr_to_sql_demo() -> Result<()> { | ||
| let expr = col("a").lt(lit(5)).or(col("a").eq(lit(8))); | ||
| let ast = expr_to_sql(&expr)?; | ||
| let sql = format!("{}", ast); | ||
| let sql = expr_to_sql(&expr)?.to_string(); |
There was a problem hiding this comment.
I don't remember why I had to do it, that totally makes sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #10558 from @xinlifoobar (🙏 ) and @edmondop
Rationale for this change
I noticed a few potential improvements to the sql_to_plan examples
What changes are included in this PR?
Are these changes tested?
Existing CI
Are there any user-facing changes?