Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples of how to convert logical plan to/from sql strings #10558

Merged
merged 4 commits into from
May 20, 2024

Conversation

xinlifoobar
Copy link
Contributor

Which issue does this PR close?

Closes #10550

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution @xinlifoobar -- this is really cool. I think we can avoid having demos for both csv and parquet files but the two usecases are very cool

datafusion-examples/examples/plan_to_sql.rs Outdated Show resolved Hide resolved
datafusion-examples/examples/plan_to_sql.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xinlifoobar -- looks great to me.

@alamb alamb merged commit 439726f into apache:main May 20, 2024
23 checks passed
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
…he#10558)

* Add examples of how to convert logical plan to/from sql strings

* Fix clippy

* fix comments

* fix comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an example of how to convert LogicalPlan to/from SQL Strings
2 participants