Minor: Fix name in ArrayFunctionRewriter, error not panic if Expr::GetStructField is planned
#10564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
May 17, 2024
| @@ -234,7 +234,7 @@ fn create_physical_name(e: &Expr, is_first_expr: bool) -> Result<String> { | |||
| stride: _, | |||
| } => { | |||
| unreachable!( | |||
| "ListRange should have been rewritten in OperatorToFunction" | |||
| "ListRange should have been rewritten in ArrayFunctionRewriter" | |||
There was a problem hiding this comment.
OperatorToFunction was the old name for these functions I think
There was a problem hiding this comment.
Actually, now that I think about this I think the issue is that we now expect that these Exprs should never be present....
I think they can still be created via Expr::field(name)...
Will double check / see if I can make a reproduicer
There was a problem hiding this comment.
Indeed -- it panics here: #10565
alamb
changed the title
alamb
changed the title
Expr::GetStructField is planned
|
@jayzhan211 has a better fix in #10568 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
While debugging a DataFusion upgrade in InfluxDB the different names for the same thing is making it hard to understand what is going on
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?