Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement unparse IsNotFalse to String #10538

Merged

Conversation

goldmedal
Copy link
Contributor

Which issue does this PR close?

No specific issue but mentioned in #10529 (comment)

Rationale for this change

What changes are included in this PR?

  • Support to unparse a IsNotFalse plan to String.
  • Reordering the expression to avoid missing the plan.

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added the sql SQL Planner label May 16, 2024
@crepererum crepererum merged commit ead66ac into apache:main May 16, 2024
23 checks passed
@goldmedal goldmedal deleted the feature/support-is-not-false-unparse branch May 16, 2024 10:29
@goldmedal
Copy link
Contributor Author

Thanks @crepererum !

findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
* support to unparse IsNotFalse

* reordering expressions in pattern matching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants