Implement unparse IS_NULL to String and enhance the tests
#10529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
previously approved these changes
May 15, 2024
There was a problem hiding this comment.
Thank you for the contribution @goldmedal -- this code looks like a great first contribution.
I just kicked off the CI checks and once we get them to pass successfully I'll merge this PR in
| Expr::IsNull(_) => not_impl_err!("Unsupported Expr conversion: {expr:?}"), | ||
| Expr::IsNull(expr) => { | ||
| Ok(ast::Expr::IsNull(Box::new(self.expr_to_sql(expr)?))) | ||
| } | ||
| Expr::IsNotFalse(_) => not_impl_err!("Unsupported Expr conversion: {expr:?}"), |
There was a problem hiding this comment.
Ah it looks like I maybe mis read the code originally and the other missing expression is Expr::IsNotFalse (rather than Expr::IsNotNull)
There was a problem hiding this comment.
Thanks for reviewing! I think I can fix IsNotFalse in another PR. What do you think?
There was a problem hiding this comment.
I think a second PR will be great
yyy1000
approved these changes
May 15, 2024
alamb
approved these changes
May 15, 2024
|
Thanks again @goldmedal -- welcome to the project! |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…0529) * implement unparse is_null and add test * format the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10519
Rationale for this change
What changes are included in this PR?
I found that
is_not_nullhas been supported. I only implement 'is_null` here.Are these changes tested?
Yes, I also added more test cases for
is_nullandis_not_null(e.g. function call and case when).Are there any user-facing changes?
No