Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Multiple Data Editor Editing / Display Items #822

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Fixed Multiple Data Editor Editing / Display Items #822

merged 1 commit into from
Aug 21, 2023

Conversation

stricklandrbls
Copy link
Collaborator

  • Fixed issue where binary display radix would still display 16 bytes per row, instead of 8.
  • Fixed inability to edit a "non-regular" sized file ( file size < 2 )
  • Rerouted all file / viewport UI offset traversal to use toplevel seek() function.

Closes #821
Closes #783

@stricklandrbls stricklandrbls added bug Something isn't working enhancement New feature or request typescript data editor Issues related to the Data Editor capability extension Issues releated to the VSCode Extension labels Aug 21, 2023
@stricklandrbls stricklandrbls added this to the 1.3.1 milestone Aug 21, 2023
@stricklandrbls stricklandrbls self-assigned this Aug 21, 2023
@stricklandrbls stricklandrbls force-pushed the highlighting-and-radix-fix branch 2 times, most recently from 71bc6f0 to 7318f81 Compare August 21, 2023 15:42
shanedell
shanedell approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@shanedell shanedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@arosien
Copy link
Contributor

arosien commented Aug 21, 2023

I have a 1-byte file with the ASCII character x. If I edit that byte, replacing the x with a y:
Screen Shot 2023-08-21 at 12 04 16 PM
then "Apply changes" (btw, I had no idea what the icon was), I get the context yx:
Screen Shot 2023-08-21 at 12 05 15 PM
I'm expecting to get only y.

@arosien
Copy link
Contributor

arosien commented Aug 21, 2023

Binary display radix shows 8 bytes per row ✔️

Screen Shot 2023-08-21 at 12 18 17 PM

@stricklandrbls
Fixed Multiple Data Editor Editing / Display Items
b0aa892 
- Fixed issue where binary display radix would still display 16 bytes
  per row, instead of 8.
- Fixed inability to edit a "non-regular" sized file ( file size < 2 )
- Rerouted all file / viewport UI offset traversal to use toplevel
  `seek()` function.

Closes apache#821
Closes apache#783
@stricklandrbls stricklandrbls force-pushed the highlighting-and-radix-fix branch from 7318f81 to b0aa892 Compare August 21, 2023 20:10
@stricklandrbls
Copy link
Collaborator Author

I have a 1-byte file with the ASCII character x. If I edit that byte, replacing the x with a y: Screen Shot 2023-08-21 at 12 04 16 PM then "Apply changes" (btw, I had no idea what the icon was), I get the context yx: Screen Shot 2023-08-21 at 12 05 15 PM I'm expecting to get only y.

Just pushed a commit that I believe fixes that issue and an issue w/ overwrite only while the file size if irregular.

arosien
arosien approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@arosien arosien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pushed a commit that I believe fixes that issue and an issue w/ overwrite only while the file size if irregular.
Confirmed.

@arosien arosien merged commit af689c7 into apache:main Aug 21, 2023
@arosien arosien deleted the highlighting-and-radix-fix branch August 21, 2023 21:08
@stricklandrbls stricklandrbls mentioned this pull request Aug 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanedell shanedell shanedell approved these changes

@arosien arosien arosien approved these changes

@scholarsmate scholarsmate Awaiting requested review from scholarsmate

@rthomas320 rthomas320 Awaiting requested review from rthomas320

@NolanMatt NolanMatt Awaiting requested review from NolanMatt

@nlewis05 nlewis05 Awaiting requested review from nlewis05

Assignees

@stricklandrbls stricklandrbls

Labels
bug Something isn't working data editor Issues related to the Data Editor capability enhancement New feature or request extension Issues releated to the VSCode Extension typescript
Projects
No open projects
daffodil-vscode-v1.3.1
Status: Done
Milestone
1.3.1
Development

Successfully merging this pull request may close these issues.

Seek / Search / Navigation Traversal Discrepancy Implement More Intuitive First & Last Byte Insertion
3 participants
@stricklandrbls @arosien @shanedell