Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement More Intuitive First & Last Byte Insertion #783

Closed
stricklandrbls opened this issue Aug 15, 2023 · 0 comments · Fixed by #822
Closed

Implement More Intuitive First & Last Byte Insertion #783

stricklandrbls opened this issue Aug 15, 2023 · 0 comments · Fixed by #822
Assignees
@stricklandrbls
Labels
data editor Issues related to the Data Editor capability enhancement New feature or request typescript
Milestone
1.4.0

Comments

@stricklandrbls
Copy link
Collaborator

Currently, in the data editor there is no "normal" way to insert a byte as the first or last byte in the displayable viewport. This is because the button overlays are injected into the wrapper position. Since there is no before or after wrapper for first and last, respectively, the user cannot use the associated buttons.

A workaround for this is to either:

  • Create a copy of the byte with the available before/after insert functionality, then edit that desired position.
  • Include the desired position in a multiple byte edit selection and then append the desired edits to in the data editor viewport.
@stricklandrbls stricklandrbls added enhancement New feature or request typescript data editor Issues related to the Data Editor capability labels Aug 15, 2023
@stricklandrbls stricklandrbls added this to the 1.4.0 milestone Aug 15, 2023
@stricklandrbls stricklandrbls self-assigned this Aug 15, 2023
@stricklandrbls stricklandrbls mentioned this issue Aug 15, 2023
Closed
stricklandrbls added a commit to ctc-oss/daffodil-vscode that referenced this issue Aug 21, 2023
@stricklandrbls
Fixed Multiple Data Editor Editing / Display Items
9179c41 
- Fixed issue where binary display radix would still display 16 bytes
  per row, instead of 8.
- Fixed inability to edit a "non-regular" sized file ( file size < 2 )
- Rerouted all file / viewport UI offset traversal to use toplevel
  `seek()` function.

Closes apache#821
Closes apache#783
@stricklandrbls stricklandrbls mentioned this issue Aug 21, 2023
Merged
stricklandrbls added a commit to ctc-oss/daffodil-vscode that referenced this issue Aug 21, 2023
@stricklandrbls
Fixed Multiple Data Editor Editing / Display Items
71bc6f0 
- Fixed issue where binary display radix would still display 16 bytes
  per row, instead of 8.
- Fixed inability to edit a "non-regular" sized file ( file size < 2 )
- Rerouted all file / viewport UI offset traversal to use toplevel
  `seek()` function.

Closes apache#821
Closes apache#783
stricklandrbls added a commit to ctc-oss/daffodil-vscode that referenced this issue Aug 21, 2023
@stricklandrbls
Fixed Multiple Data Editor Editing / Display Items
7318f81 
- Fixed issue where binary display radix would still display 16 bytes
  per row, instead of 8.
- Fixed inability to edit a "non-regular" sized file ( file size < 2 )
- Rerouted all file / viewport UI offset traversal to use toplevel
  `seek()` function.

Closes apache#821
Closes apache#783
stricklandrbls added a commit to ctc-oss/daffodil-vscode that referenced this issue Aug 21, 2023
@stricklandrbls
Fixed Multiple Data Editor Editing / Display Items
b0aa892 
- Fixed issue where binary display radix would still display 16 bytes
  per row, instead of 8.
- Fixed inability to edit a "non-regular" sized file ( file size < 2 )
- Rerouted all file / viewport UI offset traversal to use toplevel
  `seek()` function.

Closes apache#821
Closes apache#783
arosien pushed a commit that referenced this issue Aug 21, 2023
@stricklandrbls @arosien
Fixed Multiple Data Editor Editing / Display Items
af689c7 
- Fixed issue where binary display radix would still display 16 bytes
  per row, instead of 8.
- Fixed inability to edit a "non-regular" sized file ( file size < 2 )
- Rerouted all file / viewport UI offset traversal to use toplevel
  `seek()` function.

Closes #821
Closes #783
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stricklandrbls stricklandrbls

Labels
data editor Issues related to the Data Editor capability enhancement New feature or request typescript
Projects
No open projects
daffodil-vscode v1.4.0
Status: Done
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

Fixed Multiple Data Editor Editing / Display Items ctc-oss/daffodil-vscode
1 participant
@stricklandrbls