server: apply rules when VR of Domain VPC is recreated #8354

GaOrtiga · 2023-12-13T12:21:28Z

Description

After re-creating a VR from a domain VPC, ACS will not apply static nat, port forward and load balancer rules to IPs that are not associated to the account that owns the VPC.
An adjustment was made to make sure that these rules are applied for all IPs when performing the following procedures:

VR restart
VPC restart
VPC restart with cleanup
recreate VR when health-check fails
recreate VR on failover

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Bug Severity

How Has This Been Tested?

In a local lab, I performed the procedures listed in the description and verified that after applying the changes, the IPs owned by accounts different than the VPC owner were having their rules applied accordingly.

codecov · 2023-12-13T13:34:26Z

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 30.75%. Comparing base (a15b706) to head (77aa9b2).
Report is 389 commits behind head on 4.19.

Files	Patch %	Lines
...ork/router/VirtualNetworkApplianceManagerImpl.java	66.66%	0 Missing and 1 partial ⚠️
.../router/VpcVirtualNetworkApplianceManagerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #8354      +/-   ##
============================================
+ Coverage     22.25%   30.75%   +8.49%     
- Complexity    22439    33065   +10626     
============================================
  Files          5117     5353     +236     
  Lines        346819   374603   +27784     
  Branches      49790    54634    +4844     
============================================
+ Hits          77190   115196   +38006     
+ Misses       258466   244117   -14349     
- Partials      11163    15290    +4127

Flag	Coverage Δ
simulator-marvin-tests	`24.59% <50.00%> (+0.76%)`	⬆️
uitests	`4.38% <ø> (-0.07%)`	⬇️
unit-tests	`16.44% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

DaanHoogland

clgtm, looks like a good cleanup

DaanHoogland · 2023-12-14T10:40:46Z

@blueorangutan package

blueorangutan · 2023-12-14T10:42:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-12-14T11:45:45Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8051

shwstppr · 2023-12-15T10:01:52Z

@blueorangutan test

blueorangutan · 2023-12-15T10:04:03Z

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-12-16T03:36:55Z

[SF] Trillian test result (tid-8599)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 61614 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8354-t8599-kvm-centos7.zip
Smoke tests completed. 117 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_migrate_vm	`Error`	46.09	test_vm_life_cycle.py
test_01_verify_ipv6_vpc	`Error`	603.86	test_vpc_ipv6.py
test_05_rvpc_multi_tiers	`Failure`	503.24	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	503.26	test_vpc_redundant.py
test_01_redundant_vpc_site2site_vpn	`Failure`	579.31	test_vpc_vpn.py

GutoVeronezi

CLGTM

GutoVeronezi

Just a minor adjustment.

server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java

Co-authored-by: Daniel Augusto Veronezi Salvador <[email protected]>

DaanHoogland · 2024-02-16T10:13:39Z

@blueorangutan package

blueorangutan · 2024-02-16T10:14:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-02-16T11:31:56Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8685

DaanHoogland · 2024-02-16T14:55:00Z

@blueorangutan test

blueorangutan · 2024-02-16T14:56:05Z

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2024-02-17T04:08:43Z

[SF] Trillian test result (tid-9264)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45943 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8354-t9264-kvm-centos7.zip
Smoke tests completed. 128 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_upgrade_kubernetes_cluster	`Failure`	236.44	test_kubernetes_clusters.py

GaOrtiga · 2024-03-19T10:29:31Z

@DaanHoogland @GutoVeronezi @shwstppr @JoaoJandre

Is there any pending concern regarding this or can we proceed with the merge?

weizhouapache · 2024-03-19T10:32:57Z

@DaanHoogland @GutoVeronezi @shwstppr @JoaoJandre

Is there any pending concern regarding this or can we proceed with the merge?

@GaOrtiga
can you ask someone to test it, share the test steps and results ?

sureshanaparti · 2024-06-23T15:51:53Z

@DaanHoogland @GutoVeronezi @shwstppr @JoaoJandre
Is there any pending concern regarding this or can we proceed with the merge?

@GaOrtiga can you ask someone to test it, share the test steps and results ?

Ping @GaOrtiga Any update on the testing and results?

sureshanaparti

clgtm

sureshanaparti · 2024-06-26T07:52:22Z

@blueorangutan package

blueorangutan · 2024-06-26T07:54:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-06-26T08:38:58Z

Packaging result [SF]: ✔️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10142

weizhouapache · 2024-06-26T08:39:59Z

@blueorangutan package

blueorangutan · 2024-06-26T08:42:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-06-26T09:34:25Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10146

rohityadavcloud · 2024-06-26T09:45:21Z

Ping @GaOrtiga Any further update?

GaOrtiga · 2024-06-26T11:26:49Z

Ping @GaOrtiga Any further update?

No updates, just needs testing, I will check if someone can test and post results.

weizhouapache · 2024-06-27T08:22:31Z

@GaOrtiga
I am trying to test this feature. However, I cannot find any UI/doc change for the domain VPC (#7153 ).
can you please add the UI changes and create a doc PR ?

weizhouapache · 2024-06-27T09:47:19Z

tested ok. cc @sureshanaparti @GaOrtiga

GaOrtiga · 2024-06-27T13:22:21Z

@GaOrtiga I am trying to test this feature. However, I cannot find any UI/doc change for the domain VPC (#7153 ). can you please add the UI changes and create a doc PR ?

@weizhouapache Thank you for testing. Yes I will create the doc PR.

sureshanaparti · 2024-06-28T10:15:35Z

@GaOrtiga I am trying to test this feature. However, I cannot find any UI/doc change for the domain VPC (#7153 ). can you please add the UI changes and create a doc PR ?

@weizhouapache Thank you for testing. Yes I will create the doc PR.

Hi @GaOrtiga Please update the doc PR reference here once it is ready. Thanks.

GaOrtiga · 2024-06-28T17:24:37Z

@weizhouapache @sureshanaparti
Link for the doc PR:
apache/cloudstack-documentation#410

* apply rules when VR is recreated * Apply suggestions from code review Co-authored-by: Daniel Augusto Veronezi Salvador <[email protected]> Co-authored-by: Gabriel <[email protected]>

apply rules when VR is recreated

d3ff702

boring-cyborg bot added component:networking component:vpc labels Dec 13, 2023

weizhouapache changed the title ~~apply rules when VR is recreated~~ server: apply rules when VR of Domain VPC is recreated Dec 13, 2023

DaanHoogland approved these changes Dec 14, 2023

View reviewed changes

DaanHoogland added this to the 4.19.0.0 milestone Dec 14, 2023

DaanHoogland requested a review from shwstppr December 14, 2023 11:56

shwstppr modified the milestones: 4.19.0.0, 4.19.1.0 Dec 14, 2023

GutoVeronezi approved these changes Feb 14, 2024

View reviewed changes

GutoVeronezi reviewed Feb 14, 2024

View reviewed changes

server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java Outdated Show resolved Hide resolved

server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java Outdated Show resolved Hide resolved

Apply suggestions from code review

77aa9b2

Co-authored-by: Daniel Augusto Veronezi Salvador <[email protected]>

DaanHoogland changed the base branch from main to 4.19 February 16, 2024 10:13

sureshanaparti added the status:waiting-for-author label Jun 23, 2024

sureshanaparti requested a review from weizhouapache June 25, 2024 19:24

sureshanaparti added the status:needs-testing label Jun 25, 2024

sureshanaparti approved these changes Jun 25, 2024

View reviewed changes

sureshanaparti assigned weizhouapache Jun 26, 2024

weizhouapache approved these changes Jun 27, 2024

View reviewed changes

sureshanaparti removed status:waiting-for-author status:needs-testing labels Jun 28, 2024

sureshanaparti merged commit a5c8bb3 into apache:4.19 Jun 28, 2024
25 of 26 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

server: apply rules when VR of Domain VPC is recreated #8354

server: apply rules when VR of Domain VPC is recreated #8354

GaOrtiga commented Dec 13, 2023 •

edited by DaanHoogland

Loading

codecov bot commented Dec 13, 2023 •

edited

Loading

DaanHoogland left a comment

DaanHoogland commented Dec 14, 2023

blueorangutan commented Dec 14, 2023

blueorangutan commented Dec 14, 2023

shwstppr commented Dec 15, 2023

blueorangutan commented Dec 15, 2023

blueorangutan commented Dec 16, 2023

GutoVeronezi left a comment

GutoVeronezi left a comment

DaanHoogland commented Feb 16, 2024

blueorangutan commented Feb 16, 2024

blueorangutan commented Feb 16, 2024

DaanHoogland commented Feb 16, 2024

blueorangutan commented Feb 16, 2024

blueorangutan commented Feb 17, 2024

GaOrtiga commented Mar 19, 2024

weizhouapache commented Mar 19, 2024 •

edited

Loading

sureshanaparti commented Jun 23, 2024

sureshanaparti left a comment

sureshanaparti commented Jun 26, 2024

blueorangutan commented Jun 26, 2024

blueorangutan commented Jun 26, 2024

weizhouapache commented Jun 26, 2024

blueorangutan commented Jun 26, 2024

blueorangutan commented Jun 26, 2024

rohityadavcloud commented Jun 26, 2024

GaOrtiga commented Jun 26, 2024

weizhouapache commented Jun 27, 2024

weizhouapache commented Jun 27, 2024

GaOrtiga commented Jun 27, 2024

sureshanaparti commented Jun 28, 2024

GaOrtiga commented Jun 28, 2024

server: apply rules when VR of Domain VPC is recreated #8354

server: apply rules when VR of Domain VPC is recreated #8354

Conversation

GaOrtiga commented Dec 13, 2023 • edited by DaanHoogland Loading

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Bug Severity

How Has This Been Tested?

codecov bot commented Dec 13, 2023 • edited Loading

Codecov Report

DaanHoogland left a comment

Choose a reason for hiding this comment

DaanHoogland commented Dec 14, 2023

blueorangutan commented Dec 14, 2023

blueorangutan commented Dec 14, 2023

shwstppr commented Dec 15, 2023

blueorangutan commented Dec 15, 2023

blueorangutan commented Dec 16, 2023

GutoVeronezi left a comment

Choose a reason for hiding this comment

GutoVeronezi left a comment

Choose a reason for hiding this comment

DaanHoogland commented Feb 16, 2024

blueorangutan commented Feb 16, 2024

blueorangutan commented Feb 16, 2024

DaanHoogland commented Feb 16, 2024

blueorangutan commented Feb 16, 2024

blueorangutan commented Feb 17, 2024

GaOrtiga commented Mar 19, 2024

weizhouapache commented Mar 19, 2024 • edited Loading

sureshanaparti commented Jun 23, 2024

sureshanaparti left a comment

Choose a reason for hiding this comment

sureshanaparti commented Jun 26, 2024

blueorangutan commented Jun 26, 2024

blueorangutan commented Jun 26, 2024

weizhouapache commented Jun 26, 2024

blueorangutan commented Jun 26, 2024

blueorangutan commented Jun 26, 2024

rohityadavcloud commented Jun 26, 2024

GaOrtiga commented Jun 26, 2024

weizhouapache commented Jun 27, 2024

weizhouapache commented Jun 27, 2024

GaOrtiga commented Jun 27, 2024

sureshanaparti commented Jun 28, 2024

GaOrtiga commented Jun 28, 2024

GaOrtiga commented Dec 13, 2023 •

edited by DaanHoogland

Loading

codecov bot commented Dec 13, 2023 •

edited

Loading

weizhouapache commented Mar 19, 2024 •

edited

Loading