Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add section about Domain VPCs #410

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Add section about Domain VPCs #410

merged 2 commits into from
Jan 16, 2025
+20 −0

Conversation

GaOrtiga
Copy link
Contributor

@GaOrtiga GaOrtiga commented Jun 28, 2024 •
edited by github-actions bot
Loading

This was referenced Jun 28, 2024
Merged
Merged
@sureshanaparti
Copy link
Contributor

@GaOrtiga can you change the target branch to 4.19.

@GaOrtiga GaOrtiga changed the base branch from main to 4.19 June 28, 2024 18:19
@GaOrtiga GaOrtiga force-pushed the add_section_about_Domain_VPCs branch from b9ace62 to 7058749 Compare June 28, 2024 18:20
@GaOrtiga GaOrtiga force-pushed the add_section_about_Domain_VPCs branch from 7058749 to 815f947 Compare June 28, 2024 18:23
@GaOrtiga
Copy link
Contributor Author

@sureshanaparti done

DaanHoogland
DaanHoogland reviewed Jul 18, 2024
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i het it but have a few questions. Maybe in this case aan example could help.

source/adminguide/networking/virtual_private_cloud_config.rst Outdated Show resolved Hide resolved
source/adminguide/networking/virtual_private_cloud_config.rst Outdated Show resolved Hide resolved
@sureshanaparti
Copy link
Contributor

ping @GaOrtiga can you check/address the outstanding comments.

@GaOrtiga
Copy link
Contributor Author

@DaanHoogland @kiranchavala @sureshanaparti

Thank you for the reviews, I have changed all mentions of tiers or network to Network Tiers.

Are there any other concerns regarding the text?

kiranchavala
kiranchavala approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaanHoogland DaanHoogland merged commit 1bc175b into apache:4.19 Jan 16, 2025
1 check passed
DaanHoogland added a commit that referenced this pull request Jan 16, 2025
@DaanHoogland
Merge release branch 4.19 to 4.20
4fd0b51 
* 4.19:
  system vm destroy behaviour (#468)
  Add section about Domain VPCs (#410)
  Updating security group documentation (#469)
  vxlan prefix must be given to prevent interpretation as vlan (#465)
DaanHoogland added a commit that referenced this pull request Jan 16, 2025
@DaanHoogland
Merge release branch 4.20 to main
717903c 
* 4.20:
  system vm destroy behaviour (#468)
  Added command to set libvirtd to traditional mode (#462)
  Add section about Domain VPCs (#410)
  note: AMQP configuration change (#463)
  Updating security group documentation (#469)
  vxlan prefix must be given to prevent interpretation as vlan (#465)
  Updated note in compute/service offering for enable/disable VM High Availability manager setting (#464)
  Disable API Key Access for users, accounts and domains (#446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanHoogland DaanHoogland DaanHoogland left review comments

@kiranchavala kiranchavala kiranchavala approved these changes

@weizhouapache weizhouapache Awaiting requested review from weizhouapache

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GaOrtiga @sureshanaparti @kiranchavala @DaanHoogland