Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflow for greetings #318

Closed
wants to merge 1 commit into from
Closed

Conversation

sandiandian
Copy link
Contributor

Due to the low nodejs version of the github action component the run fails
and the switch is made to a newer version.

fix #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

Due to the low nodejs version of the github action component
the run fails, and the switch is made to a newer version.
@tuhaihe
Copy link
Member

tuhaihe commented Nov 29, 2023

Lots of the same issues here: actions/first-interaction#286. I tested the latest version in my personal repo, but it still failed. Does this PR succeed? If so, that would be great!

@tuhaihe tuhaihe self-requested a review November 29, 2023 03:46
@tuhaihe
Copy link
Member

tuhaihe commented Nov 30, 2023

Now that actions/first-interaction#287 has resolved the issue, all failed greeting workflows in our project are running successfully again. Thus, we can close this issue, but if the problem persists, please reopen it.

@tuhaihe tuhaihe closed this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants