-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update base image to node:20.10-buster-slim #287
Conversation
Add dependency on @octokit/rest to satisfy build requirements.
Seems like we have a build issue after the node upgrade:
Otherwise this makes sense and I'm happy to 👍 when the build's passing! |
@@ -29,8 +29,10 @@ | |||
"@actions/core": "file:toolkit/actions-core-1.10.0.tgz", | |||
"@actions/exec": "file:toolkit/actions-exec-1.1.1.tgz", | |||
"@actions/github": "file:toolkit/actions-github-5.1.1.tgz", | |||
"@actions/http-client": "^2.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wasn't able to use the local tarball like the rest of the depencies for http-client 😕
Error: Cannot find module '@actions/http-client'
is that pattern necessary to follow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also had to update the license manually from other
to mit
-> .licenses/npm/@actions/http-client.dep.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The license issue is due to http-client LICENSE
being oddly formatted, we should probably fix that.
3e2ccb7
to
f3836b2
Compare
@pje was that from https://github.com/actions/first-interaction/actions/runs/7024356281? I believe that is the current first-interaction action version 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It works, thanks! |
Add dependency on @octokit/rest to satisfy build requirements. Without @octokit/rest we would need to install
@octokit/core
,@octokit/plugin-paginate-rest
and@octokit/plugin-rest-endpoint-methods
.This should resolve #286