Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CASSGO-29, refactor packages to separate internal and public API #1857

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

CASSGO-29, refactor packages to separate internal and public API #1857

wants to merge 1 commit into from

Conversation

OleksiienkoMykyta
Copy link
Contributor

@OleksiienkoMykyta OleksiienkoMykyta commented Jan 8, 2025 •
edited
Loading

Closes #465

This was referenced Jan 9, 2025
Closed
Closed
@OleksiienkoMykyta OleksiienkoMykyta force-pushed the CASSGO-29-refactor-packages-to-separate-fronend-api-to-backend-internal-api branch from e14dad0 to 83b8c1a Compare January 13, 2025 11:40
@OleksiienkoMykyta
Copy link
Contributor Author

@joao-r-reis could you please check the PR

joao-r-reis
joao-r-reis approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@joao-r-reis joao-r-reis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot 👍 it's a very good foundation so that future code can be written with this internal vs public structure in mind and doesn't change anything on the public API.

Anything more than this at a single time will require a lot of effort and I think doing things this way with small steps at a time will work better 👍

@OleksiienkoMykyta
Copy link
Contributor Author

I like this a lot 👍 it's a very good foundation so that future code can be written with this internal vs public structure in mind and doesn't change anything on the public API.

Anything more than this at a single time will require a lot of effort and I think doing things this way with small steps at a time will work better 👍

Great. So, I will clean up a little bit, and we can push it to merge, or we keep developing this PR? I think that merging would be better, to avoid future conflicts with new features, anyway its a good start point.
Thank you for the review, I appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joao-r-reis joao-r-reis joao-r-reis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CASSGO-29 refactor packages to separate frontend api to backend internal api
2 participants
@OleksiienkoMykyta @joao-r-reis