Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP CASSGO-29 #1847

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

OleksiienkoMykyta
Copy link
Contributor

Closes #465

@OleksiienkoMykyta
Copy link
Contributor Author

@joao-r-reis, could you please check it out? It is still a little bit muddy, but it is more about the architecture. Also, I use type aliases to provide users with functionality that should be able to use, but can't be easily separated from internal logic.

Copy link
Contributor

@joao-r-reis joao-r-reis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm this will be harder than I thought. There's a lot of issues that I can see in this diff because previously exported stuff is going into an internal package.

Let's try a different approach, instead of trying to do the separation between "public" and "internal" + partioning code into different packages at the same time let's focus only on having a single internal package and let's move everything that we see is possible to move (and is unexported) to that new internal package.

We can worry about creating multiple internal packages afterwards, the difficult and complex part is making this separation of public and internal so let's focus on that first.

In this first draft let's keep everything that is exported on the public gocql package for now.

@joao-r-reis joao-r-reis changed the title WIP WIP CASSGO-29 Dec 6, 2024
@OleksiienkoMykyta
Copy link
Contributor Author

Hmm this will be harder than I thought. There's a lot of issues that I can see in this diff because previously exported stuff is going into an internal package.

Let's try a different approach, instead of trying to do the separation between "public" and "internal" + partioning code into different packages at the same time let's focus only on having a single internal package and let's move everything that we see is possible to move (and is unexported) to that new internal package.

We can worry about creating multiple internal packages afterwards, the difficult and complex part is making this separation of public and internal so let's focus on that first.

In this first draft let's keep everything that is exported on the public gocql package for now.

Okay, I will make one more implementation, and then we can compare it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CASSGO-29 refactor packages to separate frontend api to backend internal api
2 participants