Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trait): enable health trait by default #5096

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Jan 24, 2024

Closes #5024

Release Note

feat(trait): enable health trait by default

@squakez squakez added the kind/feature New feature or request label Jan 24, 2024
@gansheer
Copy link
Contributor

Nice work.

Just missing some documentation update:

// It's disabled by default.

Copy link
Contributor

✔️ Unit test coverage report - coverage increased from 34.8% to 35.4% (+0.6%)

Copy link
Contributor

✔️ Unit test coverage report - coverage increased from 34.8% to 35.4% (+0.6%)

pkg/trait/health.go Outdated Show resolved Hide resolved
Copy link
Contributor

✔️ Unit test coverage report - coverage increased from 38% to 38.1% (+0.1%)

Copy link
Contributor

github-actions bot commented May 3, 2024

✔️ Unit test coverage report - coverage increased from 38% to 38.1% (+0.1%)

@squakez squakez merged commit 0a22bed into apache:main May 3, 2024
14 checks passed
@squakez squakez deleted the feat/5024 branch May 3, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make healt trait as default
4 participants