-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Python 3.8 Support from Apache Beam #32643
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,7 +49,7 @@ jobs: | |
env: | ||
EVENT_NAME: ${{ github.event_name }} | ||
# Keep in sync with py_version matrix value below - if changed, change that as well. | ||
PY_VERSIONS_FULL: "cp38-* cp39-* cp310-* cp311-* cp312-*" | ||
PY_VERSIONS_FULL: "cp39-* cp310-* cp311-* cp312-*" | ||
outputs: | ||
gcp-variables-set: ${{ steps.check_gcp_variables.outputs.gcp-variables-set }} | ||
py-versions-full: ${{ steps.set-py-versions.outputs.py-versions-full }} | ||
|
@@ -229,7 +229,7 @@ jobs: | |
{"os": "ubuntu-20.04", "runner": [self-hosted, ubuntu-20.04, main], "python": "${{ needs.check_env_variables.outputs.py-versions-test }}", arch: "aarch64" } | ||
] | ||
# Keep in sync (remove asterisks) with PY_VERSIONS_FULL env var above - if changed, change that as well. | ||
py_version: ["cp38-", "cp39-", "cp310-", "cp311-", "cp312-"] | ||
py_version: ["cp39-", "cp310-", "cp311-", "cp312-"] | ||
steps: | ||
- name: Download python source distribution from artifacts | ||
uses: actions/[email protected] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ | |
############################################################################### | ||
|
||
# We just need to support one Python version supported by Beam. | ||
# Picking the current default Beam Python version which is Python 3.8. | ||
# Picking the current default Beam Python version which is Python 3.9. | ||
FROM python:3.9-bookworm as expansion-service | ||
LABEL Author "Apache Beam <[email protected]>" | ||
ARG TARGETOS | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -155,7 +155,7 @@ def cythonize(*args, **kwargs): | |
# Exclude 1.5.0 and 1.5.1 because of | ||
# https://github.com/pandas-dev/pandas/issues/45725 | ||
dataframe_dependency = [ | ||
'pandas>=1.4.3,!=1.5.0,!=1.5.1,<2.3;python_version>="3.8"', | ||
'pandas>=1.4.3,!=1.5.0,!=1.5.1,<2.3', | ||
] | ||
|
||
|
||
|
@@ -271,18 +271,13 @@ def get_portability_package_data(): | |
return files | ||
|
||
|
||
python_requires = '>=3.8' | ||
python_requires = '>=3.9' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (drive by): line 276 should have There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed |
||
|
||
if sys.version_info.major == 3 and sys.version_info.minor >= 12: | ||
if sys.version_info.major == 3 and sys.version_info.minor >= 13: | ||
warnings.warn( | ||
'This version of Apache Beam has not been sufficiently tested on ' | ||
'Python %s.%s. You may encounter bugs or missing features.' % | ||
(sys.version_info.major, sys.version_info.minor)) | ||
elif sys.version_info.major == 3 and sys.version_info.minor == 8: | ||
warnings.warn('Python 3.8 reaches EOL in October 2024 and support will ' | ||
'be removed from Apache Beam in version 2.61.0. See ' | ||
'https://github.com/apache/beam/issues/31192 for more ' | ||
'information.') | ||
|
||
if __name__ == '__main__': | ||
# In order to find the tree of proto packages, the directory | ||
|
@@ -534,7 +529,6 @@ def get_portability_package_data(): | |
'Intended Audience :: End Users/Desktop', | ||
'License :: OSI Approved :: Apache Software License', | ||
'Operating System :: POSIX :: Linux', | ||
'Programming Language :: Python :: 3.8', | ||
'Programming Language :: Python :: 3.9', | ||
'Programming Language :: Python :: 3.10', | ||
'Programming Language :: Python :: 3.11', | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also change the boundaries of the above condition to include 3.8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed