Remove Python 3.8 Support from Apache Beam #32643
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Since this also impacts things like the build wheels workflow this should be held until the release is further along |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
| @@ -75,12 +75,6 @@ | |||
| 'This version of Apache Beam has not been sufficiently tested on ' | |||
| 'Python %s.%s. You may encounter bugs or missing features.' % | |||
| (sys.version_info.major, sys.version_info.minor)) | |||
| elif sys.version_info.minor == 8: | |||
There was a problem hiding this comment.
We should also change the boundaries of the above condition to include 3.8
| @@ -97,15 +97,15 @@ LogOutput "Installing python and dependencies." | |||
| export DEBIAN_FRONTEND=noninteractive | |||
| apt install -y apt-transport-https ca-certificates software-properties-common curl unzip apt-utils > /dev/null 2>&1 | |||
| add-apt-repository -y ppa:deadsnakes/ppa > /dev/null 2>&1 && apt update > /dev/null 2>&1 | |||
| apt install -y python3.8 python3.8-distutils python3-pip > /dev/null 2>&1 | |||
| apt install -y --reinstall python3.8-distutils > /dev/null 2>&1 | |||
| apt install -y python3.9 python3.9-distutils python3-pip > /dev/null 2>&1 | |||
There was a problem hiding this comment.
FYI, I don't know if python3.9-distutils is available (deadsnakes/issues#150), and not sure if this package is still necessary.
There was a problem hiding this comment.
is this code exercised by some IT suite?
There was a problem hiding this comment.
I believe these scripts are invoked for playground deployment, not exercised by a test. Looks like we can get away with python3-distutils
sdks/python/setup.py
Outdated
| @@ -155,7 +155,7 @@ def cythonize(*args, **kwargs): | |||
| # Exclude 1.5.0 and 1.5.1 because of | |||
| # https://github.com/pandas-dev/pandas/issues/45725 | |||
| dataframe_dependency = [ | |||
| 'pandas>=1.4.3,!=1.5.0,!=1.5.1,<2.3;python_version>="3.8"', | |||
| 'pandas>=1.4.3,!=1.5.0,!=1.5.1,<2.3;python_version>="3.9"', | |||
There was a problem hiding this comment.
we can omit python_version>="3.9" since now it includes all the versions we support
There was a problem hiding this comment.
conditions like this make sense when we install different dependency versions depending on Python version, for example, pandas 1.x for Python 3.7, and Pandas 2.x for all other versions.
| @@ -271,18 +271,13 @@ def get_portability_package_data(): | |||
| return files | |||
|
|
|||
|
|
|||
| python_requires = '>=3.8' | |||
| python_requires = '>=3.9' | |||
There was a problem hiding this comment.
(drive by): line 276 should have >= 13 or > 12
|
The MacOS failures are due to #32811, unrelated to this PR |
Removes Python 3.8 support from Apache Beam and cleans up a number of references to the version. Also stops building 3.8 snapshot containers.
DO NOT MERGE while 2.60 release is in-flight
Part of #31192
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.