-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SolaceIO: separate auth and session settings #32406
base: master
Are you sure you want to change the base?
SolaceIO: separate auth and session settings #32406
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
@bzablocki @Abacn what are next steps on this PR? |
It's blocked by #32400, waiting for that to be merged. I'll be monitoring it and ping you once it is ready for a review. |
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/JcsmpSessionService.java
Outdated
Show resolved
Hide resolved
2996934
to
34d6ddf
Compare
This PR is unblocked now, @sjvanrossum, would you mind taking a look? :) |
...java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/SessionServiceFactory.java
Outdated
Show resolved
Hide resolved
...java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/SessionServiceFactory.java
Outdated
Show resolved
Hide resolved
… inheritance and overriding of SessionService
a208d4d
to
6afaf21
Compare
5db206f
to
b04e679
Compare
Hi @Abacn ! Would you mind taking a look a merging if it looks good? @sjvanrossum already reviewed and approved. thanks! |
Assigning reviewers. If you would like to opt out of this review, comment R: @m-trieu for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Friendly ping @m-trieu, @chamikaramj or @Abacn :) |
sorry for veing late, however I didn't see a review history for this PR. Coild you please confirm the comment above refer to this PR, and if so reviewer please review in this PR. |
Refactored to separate authentication and session settings, and allow inheritance and overriding of SessionService.
Depends on #32400, waiting for that to be merged
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.