Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SolaceIO: separate auth and session settings #32406

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bzablocki
Copy link
Contributor

@bzablocki bzablocki commented Sep 6, 2024

Refactored to separate authentication and session settings, and allow inheritance and overriding of SessionService.

Depends on #32400, waiting for that to be merged


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@liferoad liferoad requested a review from Abacn September 9, 2024 17:39
@damccorm
Copy link
Contributor

damccorm commented Oct 3, 2024

@bzablocki @Abacn what are next steps on this PR?

@bzablocki
Copy link
Contributor Author

It's blocked by #32400, waiting for that to be merged. I'll be monitoring it and ping you once it is ready for a review.

@bzablocki bzablocki force-pushed the solace-separate-auth-and-session branch 3 times, most recently from 2996934 to 34d6ddf Compare November 27, 2024 15:57
@bzablocki
Copy link
Contributor Author

This PR is unblocked now, @sjvanrossum, would you mind taking a look? :)

… inheritance and overriding of SessionService
@bzablocki bzablocki force-pushed the solace-separate-auth-and-session branch from 5db206f to b04e679 Compare December 13, 2024 15:08
@bzablocki
Copy link
Contributor Author

Hi @Abacn ! Would you mind taking a look a merging if it looks good? @sjvanrossum already reviewed and approved. thanks!

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @m-trieu for label java.
R: @chamikaramj for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@bzablocki
Copy link
Contributor Author

Friendly ping @m-trieu, @chamikaramj or @Abacn :)

@Abacn
Copy link
Contributor

Abacn commented Dec 21, 2024

sorry for veing late, however I didn't see a review history for this PR. Coild you please confirm the comment above refer to this PR, and if so reviewer please review in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants