Improve methods' javadoc

apache · Dec 13, 2024 · b04e679 · b04e679
1 parent 6afaf21
commit b04e679
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/...ava/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/JcsmpSessionService.java b/...ava/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/JcsmpSessionService.java
@@ -139,10 +139,6 @@ private MessageProducer createXMLMessageProducer(SubmissionMode submissionMode)
   }
 
   private MessageReceiver createFlowReceiver() throws JCSMPException, IOException {
-    if (isClosed()) {
-      connectReadSession();
-    }
-
     Queue queue = checkStateNotNull(queue(), "SolaceIO.Read: Queue is not set.");
 
     ConsumerFlowProperties flowProperties = new ConsumerFlowProperties();

diff --git a/...a/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/SessionServiceFactory.java b/...a/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/SessionServiceFactory.java
@@ -77,7 +77,7 @@ public abstract class SessionServiceFactory implements Serializable {
   public abstract SessionService create();
 
   /**
-   * Do not override. This method is called in the {@link
+   * This method is called in the {@link
    * org.apache.beam.sdk.io.solace.SolaceIO.Read#expand(org.apache.beam.sdk.values.PBegin)} method
    * to set the Queue reference based on {@link
    * org.apache.beam.sdk.io.solace.SolaceIO.Read#from(Solace.Queue)} or {@link
@@ -90,8 +90,8 @@ public final void setQueue(Queue queue) {
   }
 
   /**
-   * Getter for the queue. Do not override. This is nullable, because at the construction time this
-   * reference is null. Once the pipeline is compiled and the {@link
+   * Getter for the queue. This is nullable, because at the construction time this reference is
+   * null. Once the pipeline is compiled and the {@link
    * org.apache.beam.sdk.io.solace.SolaceIO.Read#expand(org.apache.beam.sdk.values.PBegin)} method
    * is called, this reference is valid.
    *