Fix flaky test StreamingDataflowWorkerTest #28173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
|
Assigning reviewers. If you would like to opt out of this review, comment R: @tvalentyn added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
tvalentyn
approved these changes
Aug 28, 2023
|
Thank you, @olalamichelle ! |
lostluck
pushed a commit
to lostluck/beam
that referenced
this pull request
Aug 30, 2023
Co-authored-by: Fei Xie <[email protected]>
|
Interestingly, after merging this test worked well for a while but became highly flaky since Sept 8th: #28383 |
Abacn
reviewed
Sep 9, 2023
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.verify; | ||
| import static org.mockito.Mockito.when; | ||
| import static org.mockito.Mockito.*; |
There was a problem hiding this comment.
btw beam does not use asterisk import, not sure why this wasn't caught by checkStyle
Abacn
added a commit
that referenced
this pull request
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use MockClock instead of real system clock to fix the test flakiness.