Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44218: [Benchmarking][Python] Avoid uwsgi install failure on macOS #44221

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Sep 25, 2024

Copy link

⚠️ GitHub issue #44218 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting review Awaiting review label Sep 25, 2024
@pitrou
Copy link
Member Author

pitrou commented Sep 25, 2024

@ursabot benchmark --help

@ursabot
Copy link

ursabot commented Sep 25, 2024

Supported benchmark command examples:

@ursabot benchmark help

To run all benchmarks:
@ursabot please benchmark

To filter benchmarks by language:
@ursabot please benchmark lang=Python
@ursabot please benchmark lang=C++
@ursabot please benchmark lang=R
@ursabot please benchmark lang=Java
@ursabot please benchmark lang=JavaScript

To filter Python and R benchmarks by name:
@ursabot please benchmark name=file-write
@ursabot please benchmark name=file-write lang=Python
@ursabot please benchmark name=file-.*

To filter C++ benchmarks by archery --suite-filter and --benchmark-filter:
@ursabot please benchmark command=cpp-micro --suite-filter=arrow-compute-vector-selection-benchmark --benchmark-filter=TakeStringRandomIndicesWithNulls/262144/2

For other command=cpp-micro options, please see https://github.com/voltrondata-labs/benchmarks/blob/main/benchmarks/cpp_micro_benchmarks.py

@pitrou
Copy link
Member Author

pitrou commented Sep 25, 2024

@ursabot please benchmark lang=C++

@ursabot
Copy link

ursabot commented Sep 25, 2024

Benchmark runs are scheduled for commit 3eb2844. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete.

@pitrou pitrou force-pushed the gh-44218-uwsgi-macos branch from 3eb2844 to 1f4c199 Compare September 25, 2024 07:13
@pitrou
Copy link
Member Author

pitrou commented Sep 25, 2024

@ursabot please benchmark lang=C++

@ursabot
Copy link

ursabot commented Sep 25, 2024

Benchmark runs are scheduled for commit 1f4c199. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete.

@pitrou pitrou marked this pull request as ready for review September 25, 2024 07:19
@pitrou pitrou changed the title GH-44218: [Benchmarking][C++] Avoid uwsgi install failure on macOS GH-44218: [Benchmarking][Python] Avoid uwsgi install failure on macOS Sep 25, 2024
@pitrou
Copy link
Member Author

pitrou commented Sep 25, 2024

This seems to fix the issue on the macOS benchmarking machine:
https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/6008

Copy link

Thanks for your patience. Conbench analyzed the 3 benchmarking runs that have been run so far on PR commit 3eb2844.

There were 15 benchmark results indicating a performance regression:

The full Conbench report has more details.

Copy link

Thanks for your patience. Conbench analyzed the 4 benchmarking runs that have been run so far on PR commit 1f4c199.

There were 11 benchmark results indicating a performance regression:

The full Conbench report has more details.

@pitrou
Copy link
Member Author

pitrou commented Sep 25, 2024

I'll merge in order to fix continuous benchmarking.

@pitrou pitrou merged commit c557fe5 into apache:main Sep 25, 2024
14 of 17 checks passed
@pitrou pitrou removed the awaiting review Awaiting review label Sep 25, 2024
@pitrou pitrou deleted the gh-44218-uwsgi-macos branch September 25, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants