Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] uwsgi fails installing on macOS arm64 benchmarking machine #44218

Closed
pitrou opened this issue Sep 24, 2024 · 5 comments
Closed

[Python] uwsgi fails installing on macOS arm64 benchmarking machine #44218

pitrou opened this issue Sep 24, 2024 · 5 comments
Assignees
@pitrou
Labels
Component: Benchmarking Component: Python Type: bug
Milestone
18.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Sep 24, 2024

Describe the bug, including details regarding any error messages, version, and platform.

See https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/5994#01921fbc-0a5c-438c-928a-761d1a14e06d/34-652

We could simply avoid installing uwsgi on macOS. It's probably enough to exercise the uwsgi-specific test on Linux.

Component(s)

Benchmarking, Python
@pitrou
Copy link
Member Author

pitrou commented Sep 24, 2024

@jorisvandenbossche What do you think?

@pitrou
Copy link
Member Author

pitrou commented Sep 25, 2024 •
edited
Loading

We could try to set the UWSGI_PYTHON_NOLIB environment variable instead:
https://github.com/unbit/uwsgi/blob/b738f550fd74ebf77cc966708d26e4f64ce2a7a3/plugins/python/uwsgiplugin.py#L45

@austin3dickey @boshek

pitrou added a commit to pitrou/arrow that referenced this issue Sep 25, 2024
@pitrou
apacheGH-44218: [Benchmarking][C++] Avoid uwsgi install failure on macOS
3eb2844
@github-actions github-actions bot mentioned this issue Sep 25, 2024
Merged
pitrou added a commit to pitrou/arrow that referenced this issue Sep 25, 2024
@pitrou
apacheGH-44218: [Benchmarking][C++] Avoid uwsgi install failure on macOS
1f4c199
pitrou added a commit that referenced this issue Sep 25, 2024
@pitrou
GH-44218: [Benchmarking][Python] Avoid uwsgi install failure on macOS (…
c557fe5 
…#44221)

* GitHub Issue: #44218

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
@pitrou pitrou added this to the 18.0.0 milestone Sep 25, 2024
@pitrou
Copy link
Member Author

pitrou commented Sep 25, 2024

Issue resolved by pull request 44221
#44221

@pitrou pitrou closed this as completed Sep 25, 2024
@jorisvandenbossche
Copy link
Member

I think the current solution to only test it on linux is also perfectly fine, but just wondering about what was going on: the uwsgi package has no wheels (and so the source install was failing), but from https://flask.palletsprojects.com/en/3.0.x/deploying/uwsgi/, it points to https://pypi.org/project/pyuwsgi/, which does have wheels.

I am not very familiar with those tools and packages, but if that package provides the same underlying tool, switching to that might actually be useful for linux as well to avoid compiling it from source on CI.

@pitrou
Copy link
Member Author

pitrou commented Sep 25, 2024

Uh, I had no idea pyuwsgi even existed. Well, we could try switching to it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pitrou pitrou

Labels
Component: Benchmarking Component: Python Type: bug
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
2 participants
@jorisvandenbossche @pitrou