GH-43986: [C++][Acero] Some code cleanup to Grouper
#43988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This is a relatively trivial change, @pitrou @felipecrv @mapleFU would you please to take a look? Thanks. |
mapleFU
reviewed
Sep 6, 2024
| @@ -332,38 +332,6 @@ Result<std::unique_ptr<RowSegmenter>> RowSegmenter::Make( | |||
|
|
|||
| namespace { | |||
|
|
|||
| struct GrouperNoKeysImpl : Grouper { | |||
There was a problem hiding this comment.
Right, not used anywhere.
github-actions
bot
added
awaiting committer review
mapleFU
approved these changes
Sep 7, 2024
This reverts commit 2af171c.
pitrou
approved these changes
Sep 9, 2024
|
Thanks for the improvements @zanmato1984 ! |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 27b43f4. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 133 possible false positives for unstable benchmarks that are known to sometimes produce them. |
khwilson
pushed a commit
to khwilson/arrow
that referenced
this pull request
Sep 14, 2024
…3988) ### Rationale for this change See apache#43986. ### What changes are included in this PR? Mostly trivial changes, plus removing one `Grouper` implementation that's not wired. ### Are these changes tested? No new tests needed. ### Are there any user-facing changes? None. * GitHub Issue: apache#43986 Authored-by: Ruoxi Sun <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See #43986.
What changes are included in this PR?
Mostly trivial changes, plus removing one
Grouperimplementation that's not wired.Are these changes tested?
No new tests needed.
Are there any user-facing changes?
None.
Grouper-related code #43986