Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Acero] Cleanup some Grouper-related code #43986

Closed
zanmato1984 opened this issue Sep 6, 2024 · 1 comment
Closed

[C++][Acero] Cleanup some Grouper-related code #43986

zanmato1984 opened this issue Sep 6, 2024 · 1 comment
Assignees
@zanmato1984
Labels
Component: C++ Type: enhancement
Milestone
18.0.0

Comments

@zanmato1984
Copy link
Contributor

Describe the enhancement requested

When reading the Grouper-related code for another optimization I'm working on, found some cleanup can be done ahead.

Component(s)

C++
@zanmato1984 zanmato1984 mentioned this issue Sep 6, 2024
Merged
pitrou pushed a commit that referenced this issue Sep 9, 2024
@zanmato1984
GH-43986: [C++][Acero] Some code cleanup to Grouper (#43988)
27b43f4 
### Rationale for this change

See #43986.

### What changes are included in this PR?

Mostly trivial changes, plus removing one `Grouper` implementation that's not wired.

### Are these changes tested?

No new tests needed.

### Are there any user-facing changes?

None.

* GitHub Issue: #43986

Authored-by: Ruoxi Sun <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
@pitrou pitrou added this to the 18.0.0 milestone Sep 9, 2024
@pitrou
Copy link
Member

pitrou commented Sep 9, 2024

Issue resolved by pull request 43988
#43988

@pitrou pitrou closed this as completed Sep 9, 2024
khwilson pushed a commit to khwilson/arrow that referenced this issue Sep 14, 2024
@zanmato1984 @khwilson
apacheGH-43986: [C++][Acero] Some code cleanup to Grouper (apache#4…
55130fa 
…3988)

### Rationale for this change

See apache#43986.

### What changes are included in this PR?

Mostly trivial changes, plus removing one `Grouper` implementation that's not wired.

### Are these changes tested?

No new tests needed.

### Are there any user-facing changes?

None.

* GitHub Issue: apache#43986

Authored-by: Ruoxi Sun <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanmato1984 zanmato1984

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
2 participants
@zanmato1984 @pitrou