GH-39720: [Swift] Switch reader to use arrow field instead of proto for building arrays #39721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abandy
changed the title
abandy
changed the title
|
|
abandy
changed the title
abandy
force-pushed
the
GH-39720
branch
2 times, most recently
from
d95dbdf to
718e1c1
Compare
kou
reviewed
Jan 22, 2024
| @@ -165,6 +167,48 @@ public class ArrowType { | |||
| return ArrowType.ArrowUnknown | |||
| } | |||
| } | |||
|
|
|||
| public static func getStride( // swiftlint:disable:this cyclomatic_complexity | |||
There was a problem hiding this comment.
How about making this a normal func (instance method) not a static func?
| nullCount: nullCount, stride: MemoryLayout<Int8>.stride) | ||
| let arrowType = ArrowType(ArrowType.ArrowBinary) | ||
| let arrowData = try ArrowData(arrowType, buffers: buffers, | ||
| nullCount: nullCount, stride: ArrowType.getStride(arrowType)) |
There was a problem hiding this comment.
How about computing stride: in ArrowData.init() because ArrowData.init() can use the given ArrowType?
github-actions
bot
added
awaiting review
github-actions
bot
added
awaiting review
|
@kou I hope all is well. Please review again when you get a chance. |
kou
changed the title
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 21ffd82. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 35 possible false positives for unstable benchmarks that are known to sometimes produce them. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…roto for building arrays (apache#39721) This PR updates the ArrowReaderHelper to use an ArrowField object for building an Array instead of a protobuf field obj. This removes leveraging protobuf from building out the Arrays and makes the code easier to reuse (like for the C Data Interface) * Closes: apache#39720 Authored-by: Alva Bandy <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Feb 28, 2024
…roto for building arrays (apache#39721) This PR updates the ArrowReaderHelper to use an ArrowField object for building an Array instead of a protobuf field obj. This removes leveraging protobuf from building out the Arrays and makes the code easier to reuse (like for the C Data Interface) * Closes: apache#39720 Authored-by: Alva Bandy <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Mar 8, 2024
…roto for building arrays (apache#39721) This PR updates the ArrowReaderHelper to use an ArrowField object for building an Array instead of a protobuf field obj. This removes leveraging protobuf from building out the Arrays and makes the code easier to reuse (like for the C Data Interface) * Closes: apache#39720 Authored-by: Alva Bandy <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the ArrowReaderHelper to use an ArrowField object for building an Array instead of a protobuf field obj. This removes leveraging protobuf from building out the Arrays and makes the code easier to reuse (like for the C Data Interface)