Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Swift] Change reader helper to use ArrowField instead of protobuf field obj for making and Array #39720

Closed
abandy opened this issue Jan 21, 2024 · 0 comments · Fixed by #39721
Closed

[Swift] Change reader helper to use ArrowField instead of protobuf field obj for making and Array #39720

abandy opened this issue Jan 21, 2024 · 0 comments · Fixed by #39721
Assignees
@abandy
Labels
Component: Swift Type: enhancement
Milestone
16.0.0

Comments

@abandy
Copy link
Contributor

abandy commented Jan 21, 2024

Describe the enhancement requested

Updating the ArrowReaderHelper to use an ArrowField for buliding Arrays.

Component(s)

Swift
@github-actions github-actions bot mentioned this issue Jan 21, 2024
Merged
kou pushed a commit that referenced this issue Jan 27, 2024
@abandy
GH-39720: [Swift] Switch reader to use arrow field instead of proto f…
21ffd82 
…or building arrays (#39721)

This PR updates the ArrowReaderHelper to use an ArrowField object for building an Array instead of a protobuf field obj.  This removes leveraging protobuf from building out the Arrays and makes the code easier to reuse (like for the C Data Interface)
* Closes: #39720

Authored-by: Alva Bandy <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 16.0.0 milestone Jan 27, 2024
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@abandy @dgreiss
apacheGH-39720: [Swift] Switch reader to use arrow field instead of p…
1b01f2a 
…roto for building arrays (apache#39721)

This PR updates the ArrowReaderHelper to use an ArrowField object for building an Array instead of a protobuf field obj.  This removes leveraging protobuf from building out the Arrays and makes the code easier to reuse (like for the C Data Interface)
* Closes: apache#39720

Authored-by: Alva Bandy <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@abandy @zanmato1984
apacheGH-39720: [Swift] Switch reader to use arrow field instead of p…
ae93898 
…roto for building arrays (apache#39721)

This PR updates the ArrowReaderHelper to use an ArrowField object for building an Array instead of a protobuf field obj.  This removes leveraging protobuf from building out the Arrays and makes the code easier to reuse (like for the C Data Interface)
* Closes: apache#39720

Authored-by: Alva Bandy <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@abandy @thisisnic
apacheGH-39720: [Swift] Switch reader to use arrow field instead of p…
87e8a67 
…roto for building arrays (apache#39721)

This PR updates the ArrowReaderHelper to use an ArrowField object for building an Array instead of a protobuf field obj.  This removes leveraging protobuf from building out the Arrays and makes the code easier to reuse (like for the C Data Interface)
* Closes: apache#39720

Authored-by: Alva Bandy <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abandy abandy

Labels
Component: Swift Type: enhancement
Projects
None yet
Milestone
16.0.0
Development

Successfully merging a pull request may close this issue.

GH-39720: [Swift] Switch reader to use arrow field instead of proto for building arrays abandy/arrow
2 participants
@kou @abandy