Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-35712: [C++][CI] MacOS Disable ASSERT_DEATH in arrow-array-test #35724

Merged
merged 1 commit into from
May 23, 2023
Merged

GH-35712: [C++][CI] MacOS Disable ASSERT_DEATH in arrow-array-test #35724

merged 1 commit into from
May 23, 2023

Conversation

mapleFU
Copy link
Member

@mapleFU mapleFU commented May 23, 2023 •
edited by github-actions bot
Loading

Rationale for this change

Disable ASSERT_DEATH in MacOS. According to #35712, it would making CI extremely slow.

What changes are included in this PR?

Disable test in macos

Are these changes tested?

no

Are there any user-facing changes?

no

@github-actions
Copy link

@mapleFU
Copy link
Member Author

mapleFU commented May 23, 2023

@pitrou PTAL

pitrou
pitrou approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you @mapleFU

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels May 23, 2023
@pitrou pitrou merged commit ce095e4 into apache:main May 23, 2023
@ursabot
Copy link

ursabot commented May 30, 2023

Benchmark runs are scheduled for baseline = f38943a and contender = ce095e4. ce095e4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.24% ⬆️0.03%] test-mac-arm
[Finished ⬇️0.98% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.54% ⬆️0.12%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] ce095e46 ec2-t3-xlarge-us-east-2
[Finished] ce095e46 test-mac-arm
[Finished] ce095e46 ursa-i9-9960x
[Finished] ce095e46 ursa-thinkcentre-m75q
[Finished] f38943af ec2-t3-xlarge-us-east-2
[Finished] f38943af test-mac-arm
[Finished] f38943af ursa-i9-9960x
[Finished] f38943af ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou approved these changes

Assignees
No one assigned
Labels
awaiting committer review Awaiting committer review Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI][C++] arrow-array-test slow on macOS
3 participants
@mapleFU @ursabot @pitrou